New lint: Raw slice pointer cast #9247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Alexendoo
reviewed
Jul 28, 2022
Alexendoo
reviewed
Jul 28, 2022
|
Hi @clubby789, welcome to Clippy! The lint looks good, thanks for the PR |
Alexendoo
reviewed
Jul 29, 2022
|
☔ The latest upstream changes (presumably #8957) made this pull request unmergeable. Please resolve the merge conflicts. |
clubby789
force-pushed
the
raw_slice_pointer_cast
branch
from
83b46b7 to
1711368
Compare
clubby789
force-pushed
the
raw_slice_pointer_cast
branch
from
1711368 to
30979bf
Compare
Alexendoo
reviewed
Aug 29, 2022
Co-authored-by: Alex Macleod <[email protected]>
Alexendoo
approved these changes
Aug 29, 2022
|
Looks good, thank you for the lint! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a lint to check for a raw slice being created and cast back to a pointer, suggesting
ptr::slice_from_raw_parts, to identify UB such as thomcc/rust-typed-arena#54.